Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 479006: re-apply r34183... (Closed)

Created:
11 years ago by Evan Stade
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, darin (slow to review)
Visibility:
Public.

Description

re-apply r34183 --------------- linux: theme scrollbars from GTK theme Pick the color of the slider's thumbpart and rail from the GTK theme. We cannot match the exact visual appearance of the GTK theme, as rendering engines can make arbitrary changes to the actual visual appearance. But by sampling a representative set of pixels, we ensure that we will at least match the general color scheme. BUG=10949 patch by <markus [at] chromium> original review: http://codereview.chromium.org/400027/show Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34285

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -39 lines) Patch
M chrome/browser/chromeos/main_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.cc View 1 chunk +89 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/renderer_preferences_util.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/browser/renderer_preferences_util.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/views/notifications/balloon_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/gtk_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/gtk_util.cc View 3 chunks +21 lines, -1 line 0 comments Download
M chrome/common/platform_util.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/platform_util_linux.cc View 2 chunks +1 line, -11 lines 0 comments Download
M chrome/common/platform_util_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/platform_util_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/common/renderer_preferences.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
TEST=trybots
11 years ago (2009-12-09 23:12:18 UTC) #1
asargent_no_longer_on_chrome
Do you want me to do a code review or is this just an FYI ...
11 years ago (2009-12-09 23:44:55 UTC) #2
Evan Stade
the latter (the fix is in chrome/browser/views/notifications/balloon_view_host.h)
11 years ago (2009-12-09 23:54:22 UTC) #3
Evan Stade
note the win try bot result for the 2nd patch is: http://build.chromium.org/buildbot/try-server/buildstatus?builder=win&number=11680
11 years ago (2009-12-09 23:55:01 UTC) #4
asargent_no_longer_on_chrome
11 years ago (2009-12-10 00:00:51 UTC) #5
Ok, rubber stamp lgtm.

Powered by Google App Engine
This is Rietveld 408576698