AU: Timestamp logs at startup.

AU: Timestamp logs at startup.

This will allow logs to be rotated by init/chromeos-cleanup-logs (separate CL).

BUG=5527
TEST=tested on device, chrome://system

Change-Id: I844ebd198510a8f600afa99f840624b2e65d1584

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=30291ed

[petkov, 2010-11-11 16:55:23]

This makes update_engine's log behavior similar to the window manager, power
manager, etc. Some of the code is copied from there.

[adlr, 2010-11-11 17:23:28]

LGTM w/ nits

http://codereview.chromium.org/4771007/diff/1/main.cc
File main.cc (right):

http://codereview.chromium.org/4771007/diff/1/main.cc#newcode97
main.cc:97: void SetUpLogSymlink(const string& symlink_path, const string&
log_path) {
all the other setup functions don't capitalize the U in up.

http://codereview.chromium.org/4771007/diff/1/main.cc#newcode121
main.cc:121: string SetupLogFile(const string kLogsRoot) {
const string&?

(yeah, here it doesn't matter, but should it ever be called w/ a real string
object it would make a copy)

[petkov, 2010-11-12 18:14:44]

Addressed comments and fixed a permission issue showing up by testing
chrome://system. Could you PTAL? Thanks.

http://codereview.chromium.org/4771007/diff/1/main.cc
File main.cc (right):

http://codereview.chromium.org/4771007/diff/1/main.cc#newcode97
main.cc:97: void SetUpLogSymlink(const string& symlink_path, const string&
log_path) {
On 2010/11/11 17:23:28, adlr wrote:
> all the other setup functions don't capitalize the U in up.

copy/paste... fixed.

http://codereview.chromium.org/4771007/diff/1/main.cc#newcode121
main.cc:121: string SetupLogFile(const string kLogsRoot) {
On 2010/11/11 17:23:28, adlr wrote:
> const string&?
> 
> (yeah, here it doesn't matter, but should it ever be called w/ a real string
> object it would make a copy)

Duh.. Done.

[adlr, 2010-11-12 18:15:45]

LGTM!

thanks!