Issue 477008: Chromium side of https://bugs.webkit.org/show_bug.cgi?id=32336...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 477008: Chromium side of https://bugs.webkit.org/show_bug.cgi?id=32336... (Closed)

Created:
11 years ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
michaeln

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Chromium side of https://bugs.webkit.org/show_bug.cgi?id=32336 Update the resource type translation from webkit into chrome. BUG=none TEST=none

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	webkit/glue/weburlloader_impl.cc	View		1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

We can land this after we land webkit bug 32336, and then priorities are all ...

11 years ago (2009-12-09 20:19:13 UTC) #1

michaeln

11 years ago (2009-12-09 23:38:12 UTC) #2

On 2009/12/09 20:19:13, Mike Belshe wrote:
> We can land this after we land webkit bug 32336, and then priorities are all
> hooked up.

Can we do this w/o the dreaded two-sided patch dance?

On the chrome-side...
* comment out the NOTREACHED() on line 125, and commit

On the webkit-side...
* Add the new enum types, but retain the old values with different case
temporatily (TargetIsSubFrame and TargetIsSubResource), and commit

On the chrome-side
* use the new enum values and commit

On the webkit-side
* remove the obsolete TargetIsSubFrame and TargetIsSubResource types

Expand Messages | Collapse Messages