Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 4770001: roll ffmpeg to nov 4 to fix clang issue (Closed)

Created:
10 years, 1 month ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, Alpha Left Google, awong, Paweł Hajdan Jr., scherkus (not reviewing)
Visibility:
Public.

Description

roll ffmpeg to nov 4 to fix clang issue BUG=61931 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65784

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/ffmpeg/ffmpeg_common.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/ffmpeg/ffmpeg_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fbarchard
av_get_bits_per_sample_fmt change requires new sigs (done) and roll at same time as source code update. ...
10 years, 1 month ago (2010-11-10 20:44:25 UTC) #1
scherkus (not reviewing)
LGTM http://codereview.chromium.org/4770001/diff/5001/media/ffmpeg/ffmpeg_common.h File media/ffmpeg/ffmpeg_common.h (right): http://codereview.chromium.org/4770001/diff/5001/media/ffmpeg/ffmpeg_common.h#newcode19 media/ffmpeg/ffmpeg_common.h:19: #include <libavcore/samplefmt.h> alphabetical ordering (libavcodec > libavcore)
10 years, 1 month ago (2010-11-11 01:54:34 UTC) #2
scherkus (not reviewing)
that is... LGTM w/ one tiny nit!
10 years, 1 month ago (2010-11-11 01:54:46 UTC) #3
fbarchard
10 years, 1 month ago (2010-11-11 02:19:43 UTC) #4
http://codereview.chromium.org/4770001/diff/5001/media/ffmpeg/ffmpeg_common.h
File media/ffmpeg/ffmpeg_common.h (right):

http://codereview.chromium.org/4770001/diff/5001/media/ffmpeg/ffmpeg_common.h...
media/ffmpeg/ffmpeg_common.h:19: #include <libavcore/samplefmt.h>
On 2010/11/11 01:54:34, scherkus wrote:
> alphabetical ordering (libavcodec > libavcore)

Done.

Powered by Google App Engine
This is Rietveld 408576698