gtk: Improve menu appearance.

gtk: Improve menu appearance.

This disables icons in menus (we weren't showing them for
most menus but were still using the ugly GTK defaults in the
omnibox) and cuts down on the huge amount of empty space to
the left of menu items' text.

(Note that the excessive spacing is still present in the
wrench menu, though.)

Change-Id: I421cc29ff2108ac5f478e380409d0ec50735c28f

BUG=chromium-os:4345
TEST=build and tried it

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8c79983

[Daniel Erat, 2010-11-10 18:12:16]

I've attached a screenshot to the bug.

[xiyuan, 2010-11-10 18:15:30]

LGTM

[Nathan Williams, 2010-11-10 19:51:29]

What does this do to the menus that are using icons (notably, the network menu,
where we show significant information about the network in the icon)? Does their
use of icons override this, or did we just lose those icons?

[Daniel Erat, 2010-11-10 21:49:02]

Yikes, this did disable those.  Reverting... :-(

On Wed, Nov 10, 2010 at 11:51 AM,  <njw@chromium.org> wrote:
> What does this do to the menus that are using icons (notably, the network
> menu,
> where we show significant information about the network in the icon)? Does
> their
> use of icons override this, or did we just lose those icons?
>
> http://codereview.chromium.org/4769001/
>

[xiyuan, 2010-11-10 21:51:00]

How about explicitly turn on menu icon for the network menu?

On 2010/11/10 21:49:02, Daniel Erat wrote:
> Yikes, this did disable those.  Reverting... :-(
> 
> On Wed, Nov 10, 2010 at 11:51 AM,  <mailto:njw@chromium.org> wrote:
> > What does this do to the menus that are using icons (notably, the network
> > menu,
> > where we show significant information about the network in the icon)? Does
> > their
> > use of icons override this, or did we just lose those icons?
> >
> > http://codereview.chromium.org/4769001/
> >

[Daniel Erat, 2010-11-10 21:52:07]

Makes sense if it's possible.  I'll revert in the meantime, though.

On Wed, Nov 10, 2010 at 1:51 PM,  <xiyuan@chromium.org> wrote:
> How about explicitly turn on menu icon for the network menu?
>
> On 2010/11/10 21:49:02, Daniel Erat wrote:
>>
>> Yikes, this did disable those.  Reverting... :-(
>
>> On Wed, Nov 10, 2010 at 11:51 AM,  <mailto:njw@chromium.org> wrote:
>> > What does this do to the menus that are using icons (notably, the
>> > network
>> > menu,
>> > where we show significant information about the network in the icon)?
>> > Does
>> > their
>> > use of icons override this, or did we just lose those icons?
>> >
>> > http://codereview.chromium.org/4769001/
>> >
>
>
>
> http://codereview.chromium.org/4769001/
>