Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8085)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/infobars/infobar_container.cc

Issue 4767001: Make TabContents own its infobar delegates.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/tab_contents/tab_contents.cc ('K') | « chrome/browser/tab_contents/tab_contents.cc ('k') | chrome/browser/ui/views/infobars/infobars.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/infobars/infobar_container.cc
===================================================================
--- chrome/browser/ui/views/infobars/infobar_container.cc (revision 65558)
+++ chrome/browser/ui/views/infobars/infobar_container.cc (working copy)
@@ -104,8 +104,8 @@
} else if (type == NotificationType::TAB_CONTENTS_INFOBAR_REMOVED) {
RemoveInfoBar(Details<InfoBarDelegate>(details).ptr(), true); // animated
} else if (type == NotificationType::TAB_CONTENTS_INFOBAR_REPLACED) {
- std::pair<InfoBarDelegate*, InfoBarDelegate*>* delegates =
- Details<std::pair<InfoBarDelegate*, InfoBarDelegate*> >(details).ptr();
+ typedef std::pair<InfoBarDelegate*, InfoBarDelegate*> Delegates;
tfarina 2010/11/10 13:11:57 Was this change really necessary? What is wrong wi
+ Delegates* delegates = Details<Delegates>(details).ptr();
ReplaceInfoBar(delegates->first, delegates->second);
} else {
NOTREACHED();
« chrome/browser/tab_contents/tab_contents.cc ('K') | « chrome/browser/tab_contents/tab_contents.cc ('k') | chrome/browser/ui/views/infobars/infobars.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698