Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2333)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/tab_contents/tab_contents.h

Issue 4767001: Make TabContents own its infobar delegates.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/gtk/infobar_gtk.cc ('K') | « chrome/browser/gtk/infobar_gtk.cc ('k') | chrome/browser/tab_contents/tab_contents.cc » ('j') | chrome/browser/tab_contents/tab_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/tab_contents.h
===================================================================
--- chrome/browser/tab_contents/tab_contents.h (revision 65558)
+++ chrome/browser/tab_contents/tab_contents.h (working copy)
@@ -470,7 +470,7 @@
// Enumeration and access functions.
int infobar_delegate_count() const { return infobar_delegates_.size(); }
InfoBarDelegate* GetInfoBarDelegateAt(int index) {
- return infobar_delegates_.at(index);
+ return infobar_delegates_[index];
tfarina 2010/11/10 13:11:57 hum? Why? What is the benefit?
}
// Toolbars and such ---------------------------------------------------------
@@ -1191,7 +1191,8 @@
// Data for shelves and stuff ------------------------------------------------
// Delegates for InfoBars associated with this TabContents.
- std::vector<InfoBarDelegate*> infobar_delegates_;
+ typedef std::vector<InfoBarDelegate*> InfoBarDelegates;
+ InfoBarDelegates infobar_delegates_;
// Data for find in page -----------------------------------------------------
« chrome/browser/gtk/infobar_gtk.cc ('K') | « chrome/browser/gtk/infobar_gtk.cc ('k') | chrome/browser/tab_contents/tab_contents.cc » ('j') | chrome/browser/tab_contents/tab_contents.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698