Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/gtk/infobar_container_gtk.cc

Issue 4767001: Make TabContents own its infobar delegates.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context_unittest.cc ('k') | chrome/browser/gtk/infobar_gtk.h » ('j') | chrome/browser/gtk/infobar_gtk.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/infobar_container_gtk.cc
===================================================================
--- chrome/browser/gtk/infobar_container_gtk.cc (revision 65711)
+++ chrome/browser/gtk/infobar_container_gtk.cc (working copy)
@@ -123,8 +123,8 @@
} else if (type == NotificationType::TAB_CONTENTS_INFOBAR_REMOVED) {
RemoveInfoBar(Details<InfoBarDelegate>(details).ptr(), true);
} else if (type == NotificationType::TAB_CONTENTS_INFOBAR_REPLACED) {
- std::pair<InfoBarDelegate*, InfoBarDelegate*>* delegates =
- Details<std::pair<InfoBarDelegate*, InfoBarDelegate*> >(details).ptr();
+ typedef std::pair<InfoBarDelegate*, InfoBarDelegate*> Delegates;
+ Delegates* delegates = Details<Delegates>(details).ptr();
Evan Stade 2010/11/11 22:39:47 nit: can you call it DelegatePair?
Peter Kasting 2010/11/11 22:47:58 Good idea. Changed typedef and variable names her
// By not animating the removal/addition, this appears to be a replace.
RemoveInfoBar(delegates->first, false);
« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context_unittest.cc ('k') | chrome/browser/gtk/infobar_gtk.h » ('j') | chrome/browser/gtk/infobar_gtk.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698