Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1723)

Unified Diff: chrome/browser/gtk/translate/translate_infobar_base_gtk.cc

Issue 4767001: Make TabContents own its infobar delegates.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
===================================================================
--- chrome/browser/gtk/translate/translate_infobar_base_gtk.cc (revision 65711)
+++ chrome/browser/gtk/translate/translate_infobar_base_gtk.cc (working copy)
@@ -179,10 +179,6 @@
return id;
}
-TranslateInfoBarDelegate* TranslateInfoBarBase::GetDelegate() const {
- return static_cast<TranslateInfoBarDelegate*>(delegate());
-}
-
// static
GtkWidget* TranslateInfoBarBase::BuildOptionsMenuButton() {
GtkWidget* button = gtk_button_new();
@@ -205,6 +201,8 @@
}
void TranslateInfoBarBase::OnOptionsClicked(GtkWidget* sender) {
+ if (!delegate())
+ return;
if (!options_menu_model_.get()) {
options_menu_model_.reset(new OptionsMenuModel(GetDelegate()));
options_menu_menu_.reset(new MenuGtk(NULL, options_menu_model_.get()));

Powered by Google App Engine
This is Rietveld 408576698