Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5325)

Unified Diff: chrome/browser/gtk/extension_view_gtk.cc

Issue 4767001: Make TabContents own its infobar delegates.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gtk/extension_view_gtk.cc
===================================================================
--- chrome/browser/gtk/extension_view_gtk.cc (revision 65711)
+++ chrome/browser/gtk/extension_view_gtk.cc (working copy)
@@ -42,14 +42,6 @@
container_->OnExtensionPreferredSizeChanged(this, new_size);
}
-void ExtensionViewGtk::CreateWidgetHostView() {
- DCHECK(!render_widget_host_view_);
- render_widget_host_view_ = new RenderWidgetHostViewGtk(render_view_host());
- render_widget_host_view_->InitAsChild();
-
- extension_host_->CreateRenderViewSoon(render_widget_host_view_);
-}
-
void ExtensionViewGtk::RenderViewCreated() {
if (!pending_background_.empty() && render_view_host()->view()) {
render_widget_host_view_->SetBackground(pending_background_);
@@ -62,3 +54,15 @@
ExtensionPopupGtk::kMaxHeight);
extension_host_->DisableScrollbarsForSmallWindows(largest_popup_size);
}
+
+virtual ExtensionViewGtk::~ExtensionViewGtk() {
+ gtk_widget_unparent(native_view());
+}
+
+void ExtensionViewGtk::CreateWidgetHostView() {
+ DCHECK(!render_widget_host_view_);
+ render_widget_host_view_ = new RenderWidgetHostViewGtk(render_view_host());
+ render_widget_host_view_->InitAsChild();
+
+ extension_host_->CreateRenderViewSoon(render_widget_host_view_);
+}

Powered by Google App Engine
This is Rietveld 408576698