Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5944)

Unified Diff: chrome/browser/cocoa/infobar_controller_unittest.mm

Issue 4767001: Make TabContents own its infobar delegates.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/infobar_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/infobar_controller_unittest.mm (revision 65711)
+++ chrome/browser/cocoa/infobar_controller_unittest.mm (working copy)
@@ -30,10 +30,11 @@
@end
-// Calls to removeDelegate: normally start an animation, which removes the
-// infobar completely when finished. For unittesting purposes, we create a mock
-// container which calls close: immediately, rather than kicking off an
-// animation.
+// Calls to removeDelegate: normally (a) start an animation, which removes the
+// infobar completely when finished; and (b) synchronously close the delegate.
+// For unittesting purposes, we create a mock container which calls close:
+// immediately, rather than kicking off an animation; the delegate is still
+// closed synchronously.
@interface InfoBarContainerTest : NSObject <InfoBarContainer> {
InfoBarController* controller_;
}
@@ -52,6 +53,7 @@
- (void)removeDelegate:(InfoBarDelegate*)delegate {
[controller_ close];
+ delegate->InfoBarClosed();
}
- (void)removeController:(InfoBarController*)controller {

Powered by Google App Engine
This is Rietveld 408576698