Preview CL for adding an Infobar facility to Google Chrome Frame....

chrome_frame/infobars/content.h

Index: chrome_frame/infobars/content.h
===================================================================
--- chrome_frame/infobars/content.h	(revision 0)
+++ chrome_frame/infobars/content.h	(revision 0)
@@ -0,0 +1,43 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_FRAME_INFOBARS_CONTENT_H_
+#define CHROME_FRAME_INFOBARS_CONTENT_H_
+
+#include <windows.h>
+
+class InfobarContent {

[tommi (sloooow) - chröme, 2010/11/24 16:08:24]

add a few comments that explain the purpose of these interfaces

[grt (UTC plus 2), 2010/11/25 18:00:13]

Consider a name change for this and other interface classes: Chrome style guide
says "The Google style guide encourages (and in some case requires) the use of
the "Interface" suffix for pure virtual interfaces. In many cases, we use
"Delegate" instead."

[erikwright (departed), 2010/12/01 20:05:52]

Thanks. I looked at the Google C++ guide. It doesn't seem to express an opinion
as to whether Interface is required (unless there are pure-virtual subclasses).

I find it a bit awkward to say "this member is an InfobarContentInterface" - to
me, the member is "an InfobarContent".

I did make some other changes to the names (mainly, in my opinion, reducing
redundancy). Some of them are simply called "Delegate" (nested within the class
to which they are a delegate), which I find natural.

+ public:
+  class ContentFrame {
+   public:
+    virtual ~ContentFrame() {}
+    // Returns the window in which the infobar content will be displayed.
+    virtual HWND GetFrameWindow() = 0;
+    // Initiates closing of the infobar.
+    virtual void CloseInfobar() = 0;
+  };
+
+  virtual ~InfobarContent() {}
+
+  // Prepares the content to display in the provided frame.
+  //
+  // The frame pointer must remain valid until a future call to Reset returns.
+  virtual bool InstallInFrame(ContentFrame* frame) = 0;
+
+  // Informs the content that it is no longer being displayed and that it, and
+  // its resources, will no longer be accessed by the ContentFrame. The
+  // InfobarContent may release itself or its resources during or after this
+  // call.
+  virtual void Reset() = 0;
+
+  // Provides the content with the dimensions available to it for display.
+  virtual void SetDimensions(const RECT& dimensions) = 0;
+
+  // Finds the desired value for one dimension given a fixed value for the other
+  // dimension. The fixed dimension parameter is non-zero whereas the requested
+  // dimension parameter will be zero.
+  virtual size_t GetDesiredSize(size_t width, size_t height) = 0;
+};

[grt (UTC plus 2), 2010/11/25 18:00:13]

I see classes and namespaces terminated with comments like this:
};  // class InfobarContent
in the codebase (note the two spaces).  I find them handy.  If you don't object,
please add.

[erikwright (departed), 2010/12/01 20:05:52]

Done.

+
+#endif  // CHROME_FRAME_INFOBARS_CONTENT_H_
Property changes on: chrome_frame\infobars\content.h
___________________________________________________________________
Added: svn:eol-style
   + LF