Moved --use-gl=osmesa switch out of test_launcher_utils

Moved --use-gl=osmesa switch out of test_launcher_utils.

It was affecting tests other than ui_tests and browser_tests, which potentially need to use regular GL. For example, plugins expect to be able to use regular GL with core animation.

In the future, we should be able to make more tests use osmesa by allowing a regular GL surface to be read back into an OSMesa surface in AcceleratedSurface on Mac.

TEST=ui_tests, browser_tests
BUG=62602
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65604

[Ken Russell (switch to Gerrit), 2010-11-10 00:48:48]

LGTM

[Paweł Hajdan Jr., 2010-11-10 12:01:24]

Drive-by with test comments. Please do a follow-up CL.

Now the GL-related code is duplicated, and that's bad. Could you add another
function to test_launcher_utils that would only be called by ui_tests and
browser_tests?

[apatrick, 2010-11-10 18:12:07]

I actually plan to completely change how this works and there will
definitely be a follow up. I did not realize from the outset that some
tests, the mac flash plugin tests in this case, would require the operating
system's regular GL implementation and not work at all with osmesa.

Plan B, which I will start on today, is to not specify "--use-gl=osmesa" by
default for any tests. I will make our GL bindings fail any tests that need
to use GL unless they explicitly specify with "--use-gl" which particular GL
implementation should be used.

I notice that not all the tests that use GL run on the trybots, which is
going to make tracking them all down difficult.

Any thoughts on any of the above?

On Wed, Nov 10, 2010 at 4:01 AM, <phajdan.jr@chromium.org> wrote:

> Drive-by with test comments. Please do a follow-up CL.
>
> Now the GL-related code is duplicated, and that's bad. Could you add
> another
> function to test_launcher_utils that would only be called by ui_tests and
> browser_tests?
>
>
> http://codereview.chromium.org/4761001/
>