Chromium Code Reviews

Issue 4758001: Part 2 of reapplying r64637. (Closed)

Created:
10 years, 1 month ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
Ben Goodger (Google)
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Nirnimesh, jam, Aaron Boodman, anantha, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, amit
Visibility:
Public.

Description

Part 2 of reapplying r64637. Move the automation message files from chrome/test/automation to chrome/common/. This requires a temporary override to chrome/common/DEPS until Part 3 lands. BUG=51409 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65695

Patch Set 1 #

Patch Set 2 : chrome_frame fix #

Patch Set 3 : more chrome_frame fix #

Patch Set 4 : More chrome_frame fix #

Total comments: 1

Patch Set 5 : Window recompile after rebase? #

Unified diffs Side-by-side diffs Stats (+114 lines, -123 lines)
M ceee/ie/plugin/bho/browser_helper_object.cc View 1 chunk +1 line, -1 line 0 comments
M ceee/ie/plugin/toolband/tool_band.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/automation_provider.h View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/automation_provider.cc View 2 chunks +1 line, -1 line 0 comments
M chrome/browser/automation/automation_provider_gtk.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/automation_provider_json.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/automation_provider_mac.mm View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/automation_provider_observers.h View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/automation_provider_win.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/automation_resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/automation_resource_tracker.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/chrome_frame_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/extension_port_container.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/testing_automation_provider_views.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/ui_controls_linux.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/automation/url_request_automation_job.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/extensions/extension_uitest.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/external_tab_container_win.cc View 2 chunks +1 line, -1 line 0 comments
M chrome/chrome.gyp View 1 chunk +0 lines, -4 lines 0 comments
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -6 lines 0 comments
M chrome/chrome_common.gypi View 1 chunk +3 lines, -0 lines 0 comments
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments
M chrome/common/DEPS View 1 chunk +9 lines, -0 lines 0 comments
M chrome/common/automation_constants.h View 1 chunk +36 lines, -0 lines 0 comments
A + chrome/common/automation_messages.h View 3 chunks +7 lines, -8 lines 0 comments
A + chrome/common/automation_messages.cc View 1 chunk +2 lines, -2 lines 0 comments
A + chrome/common/automation_messages_internal.h View 1 chunk +1 line, -1 line 0 comments
M chrome/test/automation/autocomplete_edit_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments
D chrome/test/automation/automation_constants.h View 1 chunk +0 lines, -46 lines 0 comments
M chrome/test/automation/automation_handle_tracker.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/test/automation/automation_proxy.h View 1 chunk +1 line, -1 line 0 comments
M chrome/test/automation/automation_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments
M chrome/test/automation/automation_proxy_uitest.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/test/automation/browser_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments
M chrome/test/automation/extension_proxy.h View 1 chunk +1 line, -1 line 0 comments
M chrome/test/automation/extension_proxy.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/test/automation/tab_proxy.h View 1 chunk +1 line, -1 line 0 comments
M chrome/test/automation/tab_proxy.cc View 1 chunk +1 line, -2 lines 0 comments
M chrome/test/automation/window_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments
M chrome/test/pyautolib/pyautolib.i View 1 chunk +3 lines, -2 lines 0 comments
M chrome/test/reliability/page_load_test.cc View 2 chunks +1 line, -1 line 0 comments
M chrome/test/ui/ui_test.cc View 2 chunks +1 line, -1 line 0 comments
M chrome_frame/cfproxy.h View 1 chunk +1 line, -1 line 0 comments
M chrome_frame/cfproxy_proxy.cc View 1 chunk +1 line, -1 line 0 comments
M chrome_frame/cfproxy_support.cc View 1 chunk +1 line, -1 line 0 comments
M chrome_frame/cfproxy_test.cc View 1 chunk +1 line, -1 line 0 comments
M chrome_frame/chrome_frame_delegate.h View 1 chunk +1 line, -1 line 0 comments
M chrome_frame/external_tab.h View 1 chunk +2 lines, -2 lines 0 comments
M chrome_frame/external_tab.cc View 1 chunk +1 line, -1 line 0 comments
M chrome_frame/external_tab_test.cc View 1 chunk +1 line, -1 line 0 comments
M chrome_frame/plugin_url_request.cc View 1 chunk +1 line, -1 line 0 comments
M chrome_frame/test/net/test_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments
M chrome_frame/test/reliability/page_load_test.cc View 2 chunks +1 line, -1 line 0 comments
M ipc/ipc_message_impl_macros.h View 2 chunks +1 line, -1 line 0 comments
M ipc/ipc_message_macros.h View 1 chunk +2 lines, -2 lines 0 comments

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Part 2. The check_deps override will be undone in part 3. The majority of this ...
10 years, 1 month ago (2010-11-10 00:58:30 UTC) #1
Ben Goodger (Google)
10 years, 1 month ago (2010-11-10 19:12:56 UTC) #2 
LGTM

http://codereview.chromium.org/4758001/diff/8001/chrome/common/DEPS
File chrome/common/DEPS (right):

http://codereview.chromium.org/4758001/diff/8001/chrome/common/DEPS#newcode27
chrome/common/DEPS:27: "+chrome/browser/tab_contents",
Make this comment a TODO. I will haunt you later if you forget about it!

Powered by Google App Engine