Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 4755001: Change update logic to be backwards compatible with old format. (Closed)

Created:
10 years, 1 month ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Nick Sanders
Visibility:
Public.

Description

Change update logic to be backwards compatible with old format. The key change is transforming var/...* to var_new/...* and dev_image/...* to dev_image_new/...* so that the tar file can be directly extracted to the stateful partition and have the same format for chromeos_startup as the old format. Change-Id: I0148ae76bd664e3cc4b7762c23513ceac38d517e BUG=8885 TEST=Tested with other CL by running stateful_update on a VM Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4195fad

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change to use ^ #

Patch Set 3 : .'s are unnecessary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M autoupdate.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M stateful_update View 2 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sosa
Bonus ... less lines of code.
10 years, 1 month ago (2010-11-09 21:27:48 UTC) #1
petkov
http://codereview.chromium.org/4755001/diff/1/autoupdate.py File autoupdate.py (right): http://codereview.chromium.org/4755001/diff/1/autoupdate.py#newcode264 autoupdate.py:264: '--transform="s,dev_image,dev_image_new,"', Maybe s,^dev_image,... and s,^var,... Otherwise if any filename ...
10 years, 1 month ago (2010-11-09 21:31:12 UTC) #2
sosa
PTAL http://codereview.chromium.org/4755001/diff/1/autoupdate.py File autoupdate.py (right): http://codereview.chromium.org/4755001/diff/1/autoupdate.py#newcode264 autoupdate.py:264: '--transform="s,dev_image,dev_image_new,"', Good call on first. I personally prefer ...
10 years, 1 month ago (2010-11-09 21:51:46 UTC) #3
sosa
PTAL, removed . as it was wrong since I copy the individual folders. Added test= ...
10 years, 1 month ago (2010-11-09 22:41:42 UTC) #4
petkov
10 years, 1 month ago (2010-11-09 22:46:31 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698