src/string.js - Issue 4750003: Make String.prototype.split honor limit when separator is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string.js

Issue 4750003: Make String.prototype.split honor limit when separator is empty. (Closed)

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/string.js

diff --git a/src/string.js b/src/string.js

index d82ce05237ef2def6e2050d9520098db50edeb54..a82a3545962e75c7bd0c7dd32574f7e2eba9b676 100644

--- a/src/string.js

+++ b/src/string.js

@@ -552,7 +552,7 @@ function StringSplit(separator, limit) {

var separator_length = separator.length;

// If the separator string is empty then return the elements in the subject.

- if (separator_length === 0) return %StringToArray(subject);

+ if (separator_length === 0) return %StringToArray(subject, limit);

Mads Ager (chromium) 2010/11/10 09:45:32 Accidental indentation change?

var result = %StringSplit(subject, separator, limit);

« no previous file with comments | « src/runtime.cc ('k') | test/mjsunit/string-split.js » ('j') | no next file with comments »