Issue 4750003: Make String.prototype.split honor limit when separator is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4750003: Make String.prototype.split honor limit when separator is empty. (Closed)

Created:
10 years, 1 month ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Make String.prototype.split honor limit when separator is empty. BUG=929 Committed: http://code.google.com/p/v8/source/detail?r=5806

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -4 lines)			Patch
M	src/runtime.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/string.js	View	1 chunk	+1 line, -1 line	1 comment	Download
M	test/mjsunit/string-split.js	View	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 1 month ago (2010-11-10 09:45:32 UTC) #2

LGTM!

http://codereview.chromium.org/4750003/diff/1/src/string.js
File src/string.js (right):

http://codereview.chromium.org/4750003/diff/1/src/string.js#newcode555
src/string.js:555: if (separator_length === 0) return %StringToArray(subject,
limit);
Accidental indentation change?

Expand Messages | Collapse Messages