Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 4746002: cashew: SeviceManager: remove incorrect assert (Closed)

Created:
10 years, 1 month ago by Vince Laviano
Modified:
9 years ago
Reviewers:
Jason Glasgow
CC:
chromium-os-reviews_chromium.org, Vince Laviano
Visibility:
Public.

Description

cashew: SeviceManager: remove incorrect assert In ServiceManager::ClearDefaultCellularService, we have the following assert: DCHECK(GetService(default_cellular_service_->GetPath()) != NULL); This checks that we can look up the service pointed to by |default_cellular_service_| with GetService, meaning that it's in our |services_| collection. The intent was to check that |default_cellular_service_| points to a valid service before we attempt to interact with it, but this check is inappropriate, because it is not always true that the default service is in the |services_| collection. In OnServicesUpdate, it's possible for ClearDefaultCellularService to be called after the default service has been moved from |services_| to |old_services| in preparation for its deletion. In this scenario, GetService will fail to locate it and trip the assert even though |default_cellular_service_| still points to a valid Service object. Resolution: Remove the assert. Our expectation was incorrect. BUG=chromium-os:8935 TEST=Manual testing on device Change-Id: I941b9dd06985b92737f553b215924792c7748575 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fe2f941

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/service_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Vince Laviano
10 years, 1 month ago (2010-11-09 23:20:50 UTC) #1
Jason Glasgow
10 years, 1 month ago (2010-11-09 23:23:15 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698