Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 4746001: Add check for overflow after MUL operations in side-effect free int32 express... (Closed)

Created:
10 years, 1 month ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Add check for overflow after MUL operations in side-effect free int32 expressions. BUG=http://code.google.com/p/v8/issues/detail?id=927 TEST=test/mjsunit/regress/regress-927.js Committed: http://code.google.com/p/v8/source/detail?r=5793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M src/ia32/codegen-ia32.cc View 1 chunk +4 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-927.js View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
10 years, 1 month ago (2010-11-09 18:00:24 UTC) #1
fschneider
10 years, 1 month ago (2010-11-09 18:04:14 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698