Issue 4738004: Add facilities to fetch username/passwd credentials from private data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4738004: Add facilities to fetch username/passwd credentials from private data (Closed)

Created:
10 years, 1 month ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
Raghu Simha

CC:
chromium-reviews, John Grabowski, anantha, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add facilities to fetch username/passwd credentials from private data Fetch username/passwd from private data and use in sync tests. BUG=60970 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65634

Patch Set 1 #

Total comments: 1

Patch Set 2 : test_google_account #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -9 lines)			Patch
	M	chrome/test/functional/sync.py	View	1	3 chunks	+9 lines, -9 lines	0 comments	Download
	M	chrome/test/pyautolib/pyauto.py	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Raghu Simha

LGTM, with one nit. http://codereview.chromium.org/4738004/diff/1/chrome/test/functional/sync.py File chrome/test/functional/sync.py (right): http://codereview.chromium.org/4738004/diff/1/chrome/test/functional/sync.py#newcode15 chrome/test/functional/sync.py:15: creds = self.GetPrivateInfo()['test_google'] nit: 'test_google' ...

10 years, 1 month ago (2010-11-10 02:31:38 UTC) #2

Raghu Simha

On 2010/11/10 02:39:27, Nirnimesh wrote: > s/test_google/test_google_account/ Another thing: You'll need to enable sync.py in ...

10 years, 1 month ago (2010-11-10 03:35:31 UTC) #4

Nirnimesh

10 years, 1 month ago (2010-11-10 05:48:53 UTC) #5

On 2010/11/10 03:35:31, rsimha wrote:
> On 2010/11/10 02:39:27, Nirnimesh wrote:
> > s/test_google/test_google_account/
> 
> Another thing: You'll need to enable sync.py in PYAUTO_TESTS. Not sure if you
> meant to do this in another patch.

I'll enable in another CL. Need some more tinkering to do in the buildbot
configs to pull in the private data files.

Expand Messages | Collapse Messages