Issue 4737001: [crosutils] bump default size of VM disk to allow for bigger stateful partition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4737001: [crosutils] bump default size of VM disk to allow for bigger stateful partition (Closed)

Created:
10 years, 1 month ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

[crosutils] bump default size of VM disk to allow for bigger stateful partition BUG=8544 TEST=create an VM image with image_to_vm.sh; the stateful partition should be 2GB in size. Change-Id: I6c0ee9e2cb513e42c25e4f0d1616835a41f378d7 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7d04c7a

Patch Set 1 #

Patch Set 2 : set statefulfs_size default instead #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	image_to_vm.sh	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

10 years, 1 month ago (2010-11-09 08:37:37 UTC) #2

LGTM

On Mon, Nov 8, 2010 at 8:04 PM,  <cmasone@chromium.org> wrote:
> Reviewers: sosa,
>
> Description:
> [crosutils] bump default size of VM disk to allow for bigger stateful
> partition
>
> BUG=8544
> TEST=create an VM image with image_to_vm.sh; the disk should be 4GB in size.
>
> Change-Id: I6c0ee9e2cb513e42c25e4f0d1616835a41f378d7
>
> Please review this at http://codereview.chromium.org/4737001/show
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
>  M image_to_vm.sh
>
>
> Index: image_to_vm.sh
> diff --git a/image_to_vm.sh b/image_to_vm.sh
> index
>
fdf23a413cc93dc5d1814a1f62625388c7d44ea4..360d8b393c9d9c0b313805ca1b7258a8c847742d
> 100755
> --- a/image_to_vm.sh
> +++ b/image_to_vm.sh
> @@ -45,7 +45,7 @@ DEFINE_string to "" \
>   "Destination folder for VM output file(s)"
>  DEFINE_string vbox_disk "${DEFAULT_VBOX_DISK}" \
>   "Filename for the output disk (virtualbox only)."
> -DEFINE_integer vdisk_size 3072 \
> +DEFINE_integer vdisk_size 4096 \
>   "virtual disk size in MBs."
>  DEFINE_string vmdk "${DEFAULT_VMDK}" \
>   "Filename for the vmware disk image (vmware only)."
>
>
>

Expand Messages | Collapse Messages