Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/chromeos/status/network_menu.cc

Issue 4733001: Fix so that we don't show activate 3G in both OOBE and login screen.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/status/network_menu.cc
===================================================================
--- chrome/browser/chromeos/status/network_menu.cc (revision 65464)
+++ chrome/browser/chromeos/status/network_menu.cc (working copy)
@@ -566,10 +566,8 @@
chromeos::ActivationState activation_state =
cell_networks[i]->activation_state();
if (activation_state == ACTIVATION_STATE_NOT_ACTIVATED) {
- // If we are on the login screen, do not show activating 3G option.
- // TODO(chocobo): We are currently using ShouldOpenButtonOptions() to
- // tell whether or not we are at the login screen. We need to fix it.
- if (!ShouldOpenButtonOptions())
+ // If we are on the OOBE/login screen, do not show activating 3G option.
+ if (!IsBrowserMode())
continue;
label = l10n_util::GetStringFUTF16(
IDS_STATUSBAR_NETWORK_DEVICE_ACTIVATE,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698