[Sync] Added some basic extension sync integration tests.

chrome/test/live_sync/single_client_live_extensions_sync_test.cc

Index: chrome/test/live_sync/single_client_live_extensions_sync_test.cc
diff --git a/chrome/test/live_sync/single_client_live_extensions_sync_test.cc b/chrome/test/live_sync/single_client_live_extensions_sync_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..98c9f712094ee570a5ea8135ccb700eb0d71018f
--- /dev/null
+++ b/chrome/test/live_sync/single_client_live_extensions_sync_test.cc
@@ -0,0 +1,58 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/test/live_sync/live_extensions_sync_test.h"
+
+#include "base/basictypes.h"
+#include "chrome/common/extensions/extension.h"
+
+class SingleClientLiveExtensionsSyncTest : public LiveExtensionsSyncTest {
+ public:
+  SingleClientLiveExtensionsSyncTest()
+      : LiveExtensionsSyncTest(SINGLE_CLIENT) {}
+
+  virtual ~SingleClientLiveExtensionsSyncTest() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(SingleClientLiveExtensionsSyncTest);
+};
+
+IN_PROC_BROWSER_TEST_F(SingleClientLiveExtensionsSyncTest,
+                       StartWithNoExtensions) {
+  ASSERT_TRUE(SetupSync());
+
+  ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier());
+}
+
+IN_PROC_BROWSER_TEST_F(SingleClientLiveExtensionsSyncTest,
+                       StartWithSomeExtensions) {
+  ASSERT_TRUE(SetupClients());
+
+  const int kNumExtensions = 5;
+  for (int i = 0; i < kNumExtensions; ++i) {
+    InstallExtension(GetProfile(0), GetExtension(i));
+    InstallExtension(verifier(), GetExtension(i));
+  }
+
+  ASSERT_TRUE(SetupSync());
+
+  ASSERT_TRUE(AwaitQuiescence());

[Raghu Simha, 2010/11/12 01:40:50]

This can stay as AwaitSyncCycleCompletion. AwaitQuiescence is an expensive call,
and can sometimes slow down a test if called when only one client is making a
change.

[Raghu Simha, 2010/11/12 01:43:42]

Oh crap, AwaitQuiescence is fine here because it follows a call to SetupSync().
But my earlier comment applies in cases where both clients are synced, and only
one of them makes a change.

:)

[akalin, 2010/11/12 02:19:03]

Not needed at all!

On 2010/11/12 01:43:42, rsimha wrote:

+
+  ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier());
+}
+
+IN_PROC_BROWSER_TEST_F(SingleClientLiveExtensionsSyncTest,
+                       InstallSomeExtensions) {
+  ASSERT_TRUE(SetupSync());
+
+  const int kNumExtensions = 5;
+  for (int i = 0; i < kNumExtensions; ++i) {
+    InstallExtension(GetProfile(0), GetExtension(i));
+    InstallExtension(verifier(), GetExtension(i));
+  }
+
+  ASSERT_TRUE(AwaitQuiescence());

[Raghu Simha, 2010/11/12 01:40:50]

Same comment as above.

[akalin, 2010/11/12 02:19:03]

It's a single-client test, so AwaitQuiescence is okay as we discussed.

[Raghu Simha, 2010/11/12 02:32:20]

Yeah, in this case, it's equivalent to a call to AwaitSyncCycleCompletion in
theory, because there's only one client. However, I'd recommend directly calling
AwaitSyncCycleCompletion in single client tests. This will avoid the overhead of
2 levels of function calls, and will make the logs (when verbose logging is
enabled) easier to understand, by not spewing 3 lines of logging when only one
is sufficient.

[akalin, 2010/11/12 02:47:10]

Done.

+
+  ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier());
+}