Issue 4732002: Fix DCHECK failure in page_setup.cc on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4732002: Fix DCHECK failure in page_setup.cc on Linux. (Closed)

Created:
10 years, 1 month ago by hamaji

Modified:
9 years, 5 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, Yuzo, James Hawkins

Visibility:
Public.

Fix DCHECK failure in page_setup.cc on Linux. I think this issue was introduced in http://codereview.chromium.org/3619002 We need to subtract margins from page size to calculate the size of printable areas. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65635

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	printing/print_settings_initializer_gtk.cc	View		1 chunk	+8 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM

Apparently I suck at math.