Issue 4731001: Fix pyauto tests, to refer to chrome_command_ids.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4731001: Fix pyauto tests, to refer to chrome_command_ids.h (Closed)

Created:
10 years, 1 month ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, John Grabowski, anantha, Nirnimesh, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix pyauto tests, to refer to chrome_command_ids.h. It was broken in r6545. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65497

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/pyautolib/pyautolib.i	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM. Sorry I missed it, I only grepped source files (what is ".i"?). Please make ...

10 years, 1 month ago (2010-11-09 01:45:04 UTC) #2

Nirnimesh

10 years, 1 month ago (2010-11-09 04:02:56 UTC) #3

On 2010/11/09 01:45:04, Evan Martin wrote:
> LGTM.  Sorry I missed it, I only grepped source files (what is ".i"?).
> 

swig interface file. There's only such file.

> Please make the review description descriptive before committing.
Done

Expand Messages | Collapse Messages