Readding UI test I pulled yesterday; hopefully the bots will like it more now...

Readding UI test I pulled yesterday; hopefully the bots will like it more now. I need to wait for the bookmark bar to become visible so I plumbed in similar code as for the Find box instead of using Sleep's. 

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1809

[Finnur, 2008-09-05 19:10:40]

I don't remember if I sent this out previously (and I don't see the review
email) - so lets try this again... #clicks Publish#

[sky, 2008-09-05 19:36:46]

http://codereview.chromium.org/473/diff/1/4
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/473/diff/1/4#newcode1735
Line 1735: BookmarkBarView* bookmark_bar =
browser->window()->GetBookmarkBarView();
GetBookmarkBarView may return NULL.

http://codereview.chromium.org/473/diff/1/5
File chrome/browser/views/bookmark_bar_view.cc (right):

http://codereview.chromium.org/473/diff/1/5#newcode1075
Line 1075: if (sz.cy > 1)  // 1 is the minimum in GetPreferredSize.
nit: You could just make this return (sz.cy > 1).

Is 1 really the min? You sure you don't want 0?

http://codereview.chromium.org/473/diff/1/6
File chrome/browser/views/bookmark_bar_view.h (right):

http://codereview.chromium.org/473/diff/1/6#newcode142
Line 142: bool IsVisible();
virtual .. const.

http://codereview.chromium.org/473/diff/1/11
File chrome/test/automation/automation_messages_internal.h (right):

http://codereview.chromium.org/473/diff/1/11#newcode756
Line 756: // Is the Bookmark bar visible? The response will indicate whether it
is visible
Is this more than 80?

[Finnur, 2008-09-05 21:25:03]

You, me and Ben discussed offline that we should have this in the BrowserWindow,
since IsVisible should always return true for the BookmarkBar view (it is
currently responsible for drawing the bottom of the toolbar even when not
'visible').

This duplicates the code that checks if it is visible :(, but that will get
consolidated with Ben's reorganization of the frame code...

[sky, 2008-09-05 21:33:16]

LGTM

Happy landings.

  -Scott