Issue 4727004: Disabling the ShouldShowVersionMismatchDialog chrome frame test as it fails a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4727004: Disabling the ShouldShowVersionMismatchDialog chrome frame test as it fails a... (Closed)

Created:
10 years, 1 month ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
Jói

CC:
chromium-reviews, amit, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Disabling the ShouldShowVersionMismatchDialog chrome frame test as it fails all the time. Bug=62636 TBR=joi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65638

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome_frame/test/chrome_frame_activex_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

10 years, 1 month ago (2010-11-10 10:55:42 UTC) #2

LGTM

Hmm, that's weird, will take a look today. Thanks for marking it
disabled for now.

On Wed, Nov 10, 2010 at 1:34 AM,  <ananta@chromium.org> wrote:
> Reviewers: Jói,
>
> Description:
> Disabling the ShouldShowVersionMismatchDialog chrome frame test as it fails
> all
> the
> time.
>
> Bug=62636
> TBR=joi
>
>
> Please review this at http://codereview.chromium.org/4727004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/chrome_frame_activex_unittest.cc
>
>
> Index: chrome_frame/test/chrome_frame_activex_unittest.cc
> ===================================================================
> --- chrome_frame/test/chrome_frame_activex_unittest.cc  (revision 65626)
> +++ chrome_frame/test/chrome_frame_activex_unittest.cc  (working copy)
> @@ -52,7 +52,8 @@
>   }
>  };
>
> -TEST(ChromeFrameActivex, ShouldShowVersionMismatchDialog) {
> +// http://code.google.com/p/chromium/issues/detail?id=62636
> +TEST(ChromeFrameActivex, DISABLED_ShouldShowVersionMismatchDialog) {
>   // If not privileged, we always show the dialog.
>   ASSERT_TRUE(
>       TestingChromeFrameActivex::TestingShouldShowVersionMismatchDialog(
>
>
>

Expand Messages | Collapse Messages