chrome/test/data/extensions/api_test/extension_gallery_install/invalid_begin.html - Issue 4727001: Split the private webstore install API into two parts....

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/extension_gallery_install/invalid_begin.html

Issue 4727001: Split the private webstore install API into two parts.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/test/data/extensions/api_test/extension_gallery_install/common.js ('K') | « chrome/test/data/extensions/api_test/extension_gallery_install/complete_without_begin.html ('k') | chrome/test/data/extensions/api_test/extension_gallery_install/no_user_gesture.html » ('j') | chrome/test/data/extensions/api_test/extension_gallery_install/test.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Property Changes:

Added: svn:eol-style
+ LF

OLD	NEW
(Empty)
	1 <script src="common.js"></script>

	2 <script>

	3 // This tests that an invalid id passed to beginInstall generates an error, and

	4 // that completeInstall raises an error in this case as well.

	5 chrome.webstorePrivate.beginInstall("some invalid id", function() {

	6 assertEq(chrome.extension.lastError.message, "Invalid id");

	7

	8 chrome.webstorePrivate.completeInstall(extension_id, function() {
	Erik does not do reviews 2010/11/10 16:47:45 this seems redundant since you already have the se this seems redundant since you already have the separate complete without begin test. if you want to test that complete doesn't trigger just because someone called begin before, then it seems like a better test would be to try a different valid id for begin. I'm still not sure that's very interesting though. asargent_no_longer_on_chrome 2010/11/10 22:58:23 Agreed - I've removed this part. Show quoted text On 2010/11/10 16:47:45, Erik Kay wrote: > this seems redundant since you already have the separate complete without begin > test. if you want to test that complete doesn't trigger just because someone > called begin before, then it seems like a better test would be to try a > different valid id for begin. I'm still not sure that's very interesting > though. Agreed - I've removed this part.
	9 var expected_error = extension_id +

	10 " does not match a previous call to beginInstall";

	11 assertEq(chrome.extension.lastError.message, expected_error);

	12 succeed();

	13 });

	14 });

	15 </script>

OLD	NEW