Split the private webstore install API into two parts....

chrome/browser/extensions/extension_webstore_private_api.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_webstore_private_api.h"
 
 #include <string>
 #include <vector>
 
 #include "app/l10n_util.h"
 #include "base/string_util.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/browser/extensions/extensions_service.h"
 #include "chrome/browser/net/gaia/token_service.h"
 #include "chrome/browser/profile_manager.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/common/extensions/extension_constants.h"
+#include "chrome/common/extensions/extension_error_utils.h"
 #include "chrome/common/net/gaia/gaia_constants.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/notification_type.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "net/base/escape.h"
 
 namespace {
 
 const char* install_base_url = extension_urls::kGalleryUpdateHttpsUrl;
 const char kLoginKey[] = "login";
 const char kTokenKey[] = "token";
+const char kDeprecatedError[] = "This function is deprecated";
+const char kNoPreviousBeginInstallError[] =
+    "* does not match a previous call to beginInstall";
+const char kUserGestureRequiredError[] =
+    "This function must be called during a user gesture";
 
 ProfileSyncService* test_sync_service = NULL;
 BrowserSignin* test_signin = NULL;
+bool ignore_user_gesture_for_tests = false;
 
 // Returns either the test sync service, or the real one from |profile|.
 ProfileSyncService* GetSyncService(Profile* profile) {
   if (test_sync_service)
     return test_sync_service;
   else
     return profile->GetProfileSyncService();
 }
 
 BrowserSignin* GetBrowserSignin(Profile* profile) {
@@ skipping 42 matching lines @@
 void WebstorePrivateApi::SetTestingProfileSyncService(
     ProfileSyncService* service) {
   test_sync_service = service;
 }
 
 // static
 void WebstorePrivateApi::SetTestingBrowserSignin(BrowserSignin* signin) {
   test_signin = signin;
 }
 
+bool InstallFunction::RunImpl() {
+  error_ = kDeprecatedError;
+  return false;
+}
+
 // static
-void InstallFunction::SetTestingInstallBaseUrl(
+void BeginInstallFunction::SetIgnoreUserGestureForTests(bool ignore) {
+  ignore_user_gesture_for_tests = ignore;
+}
+
+bool BeginInstallFunction::RunImpl() {
+  if (!IsWebStoreURL(profile_, source_url()))
+    return false;
+
+  std::string id;
+  EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &id));
+  EXTENSION_FUNCTION_VALIDATE(Extension::IdIsValid(id));

[Erik does not do reviews, 2010/11/09 16:32:21]

this shouldn't be EXTENSION_FUNCTION_VALIDATE since the schema doesn't validate
it.  you should set error_ and return false.

[asargent_no_longer_on_chrome, 2010/11/10 00:23:48]

Done.

+
+  if (!user_gesture() && !ignore_user_gesture_for_tests) {
+    error_ = kUserGestureRequiredError;
+    return false;
+  }
+
+  CrxInstaller::SetWhitelistedInstallId(id);

[Erik does not do reviews, 2010/11/09 16:32:21]

add comment saying where this gets cleared, maybe talk about the TODO about
adding time expiration

[asargent_no_longer_on_chrome, 2010/11/10 00:23:48]

Done.

+  return true;
+}
+
+// static
+void CompleteInstallFunction::SetTestingInstallBaseUrl(
     const char* testing_install_base_url) {
   install_base_url = testing_install_base_url;
 }
 
-bool InstallFunction::RunImpl() {
+bool CompleteInstallFunction::RunImpl() {
   if (!IsWebStoreURL(profile_, source_url()))
     return false;
 
   std::string id;
   EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &id));
   EXTENSION_FUNCTION_VALIDATE(Extension::IdIsValid(id));

[Erik does not do reviews, 2010/11/09 16:32:21]

same here

[asargent_no_longer_on_chrome, 2010/11/10 00:23:48]

Done.

 
+  if (!CrxInstaller::IsIdWhitelisted(id)) {
+    error_ = ExtensionErrorUtils::FormatErrorMessage(
+        kNoPreviousBeginInstallError, id);
+    return false;
+  }
+
   std::vector<std::string> params;
   params.push_back("id=" + id);
   params.push_back("lang=" + g_browser_process->GetApplicationLocale());
   params.push_back("uc");
   std::string url_string = install_base_url;
 
   GURL url(url_string + "?response=redirect&x=" +
       EscapeQueryParamValue(JoinString(params, '&'), true));
   DCHECK(url.is_valid());
 
-  // Cleared in ~CrxInstaller().
-  CrxInstaller::SetWhitelistedInstallId(id);
-
   // The download url for the given |id| is now contained in |url|. We
   // navigate the current (calling) tab to this url which will result in a
   // download starting. Once completed it will go through the normal extension
   // install flow. The above call to SetWhitelistedInstallId will bypass the
   // normal permissions install dialog.
   NavigationController& controller =
       dispatcher()->delegate()->associated_tab_contents()->controller();
   controller.LoadURL(url, source_url(), PageTransition::LINK);
 
   return true;
@@ skipping 139 matching lines @@
   }
 
   DCHECK(waiting_for_token_);
 
   result_.reset(CreateLoginResult(GetDefaultProfile(profile_)));
   SendResponse(true);
 
   // Matches the AddRef in RunImpl().
   Release();
 }