chrome/browser/cocoa/extension_installed_bubble_controller.h - Issue 4724005: Add a help bubble pointing to the omnibox when installing an extension with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/extension_installed_bubble_controller.h

Issue 4724005: Add a help bubble pointing to the omnibox when installing an extension with (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/app/nibs/ExtensionInstalledBubble.xib ('k') | chrome/browser/cocoa/extension_installed_bubble_controller.mm » ('j') | chrome/browser/cocoa/extension_installed_bubble_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/cocoa/extension_installed_bubble_controller.h

diff --git a/chrome/browser/cocoa/extension_installed_bubble_controller.h b/chrome/browser/cocoa/extension_installed_bubble_controller.h

index e5f50a3d9a1d9cad667e8958beee697e0f8f8af8..4633b3fafe46fa96f4064b9d0ffdf89acbcb8ae0 100644

--- a/chrome/browser/cocoa/extension_installed_bubble_controller.h

+++ b/chrome/browser/cocoa/extension_installed_bubble_controller.h

@@ -32,6 +32,7 @@ const int kInnerVerticalMargin = 10;

// We use a different kind of notification for each of these extension types.

typedef enum {

+ kOmniboxKeyword,

Bons 2010/11/11 19:28:57 while you're in here, mind alphabetizing these?

Matt Perry 2010/11/12 07:20:25 Done.

kBrowserAction,

kPageAction,

kGeneric

@@ -68,7 +69,8 @@ typedef enum {

IBOutlet HoverCloseButton* closeButton_;

IBOutlet NSImageView* iconImage_;

IBOutlet NSTextField* extensionInstalledMsg_;

- IBOutlet NSTextField* pageActionInfoMsg_; // Only shown for page actions.

+ // Only shown for page actions and omnibox keywords.

+ IBOutlet NSTextField* extraInfoMsg_;

IBOutlet NSTextField* extensionInstalledInfoMsg_;

}