Add a help bubble pointing to the omnibox when installing an extension with

chrome/browser/extensions/extension_install_ui.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_ui.h"
 
 #include <map>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
@@ skipping 137 matching lines @@
 #if defined(TOOLKIT_VIEWS)
   if (!browser)
     return;
 
   ExtensionInstalledBubble::Show(extension, browser, icon_);
 #elif defined(OS_MACOSX)
   DCHECK(browser);
   // Note that browser actions don't appear in incognito mode initially,
   // so fall back to the generic case.
   if ((extension->browser_action() && !browser->profile()->IsOffTheRecord()) ||
+      !extension->omnibox_keyword().empty() ||
       (extension->page_action() &&
       !extension->page_action()->default_icon_path().empty())) {

[Aaron Boodman, 2010/11/11 02:55:30]

Nit: this line needs to be indented one space.

[Matt Perry, 2010/11/12 07:20:25]

Are you sure? I don't think I've ever seen a multiply-parenthesized expression
formatted that way.

[Aaron Boodman, 2010/11/12 19:04:06]

The expression "!extension->page_action()->default_icon_path().empty()" is a
child of the left paren above the exclamation point. Typically don't we do:

if (very_long_expression &&
    other_long_expression) {

}

?

[Matt Perry, 2010/11/12 23:08:18]

Yes, but I've only seen it stop there. It looks weird to me to do:

if (expr1 &&
    (expr2 &&
     expr3) &&
    expr4) {
}

but there's nothing in the style guide either way.

     ExtensionInstalledBubbleCocoa::ShowExtensionInstalledBubble(
         browser->window()->GetNativeHandle(),
         extension, browser, icon_);
   }  else {
     // If the extension is of type GENERIC, meaning it doesn't have a UI
     // surface to display for this window, launch infobar instead of popup
     // bubble, because we have no guaranteed wrench menu button to point to.
     ShowGenericExtensionInstalledInfoBar(extension);
   }
 #elif defined(TOOLKIT_GTK)
@@ skipping 137 matching lines @@
     TabContents* tab_contents, const Extension* new_theme,
     const std::string& previous_theme_id, bool previous_use_system_theme) {
 #if defined(TOOLKIT_GTK)
   return new GtkThemeInstalledInfoBarDelegate(tab_contents, new_theme,
       previous_theme_id, previous_use_system_theme);
 #else
   return new ThemeInstalledInfoBarDelegate(tab_contents, new_theme,
       previous_theme_id);
 #endif
 }