Group commandline settings in UI test and in process browser test.

chrome/test/in_process_browser_test.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_IN_PROCESS_BROWSER_TEST_H_
 #define CHROME_TEST_IN_PROCESS_BROWSER_TEST_H_
 #pragma once
 
 #include "base/compiler_specific.h"
 #include "base/ref_counted.h"
@@ skipping 131 matching lines @@
   virtual bool CreateUserDataDirectory() WARN_UNUSED_RESULT;
 
   // This is invoked from main after browser_init/browser_main have completed.
   // This prepares for the test by creating a new browser, runs the test
   // (RunTestOnMainThread), quits the browsers and returns.
   void RunTestOnMainThreadLoop();
 
   // Quits all open browsers and waits until there are no more browsers.
   void QuitBrowsers();
 
+  // Config commandlines that are common to InProcessBrowserTests.
+  void PrepareCommonInProcessBrowserTestCommandLine(CommandLine* arguments);

[Paweł Hajdan Jr., 2010/11/11 10:15:25]

nit: InProcessBrowserTest is already the class name. No need to repeat it in the
method name. I'd suggest that PrepareTestCommandLine, which would call the
common test_launcher_utils code, and then add browser_tests-specific flags.

+
   // Browser created from CreateBrowser.
   Browser* browser_;
 
   // Testing server, started on demand.
   net::TestServer test_server_;
 
   // Whether this test requires the browser windows to be shown (interactive
   // tests for example need the windows shown).
   bool show_window_;
 
@@ skipping 52 matching lines @@
             GTEST_TEST_CLASS_NAME_(test_case_name, test_name)>);\
 void GTEST_TEST_CLASS_NAME_(test_case_name, test_name)::RunTestOnMainThread()
 
 #define IN_PROC_BROWSER_TEST_F(test_fixture, test_name)\
   IN_PROC_BROWSER_TEST_(test_fixture, test_name, test_fixture,\
                     ::testing::internal::GetTypeId<test_fixture>())
 
 #endif  // defined(ALLOW_IN_PROC_BROWSER_TEST)
 
 #endif  // CHROME_TEST_IN_PROCESS_BROWSER_TEST_H_