chrome/browser/extensions/sandboxed_extension_unpacker.cc - Issue 4723007: SandboxedExtensionUnpacker::ValidateSignature should check for an empty signa...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/sandboxed_extension_unpacker.cc

Issue 4723007: SandboxedExtensionUnpacker::ValidateSignature should check for an empty signa... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/sandboxed_extension_unpacker.cc

===================================================================

--- chrome/browser/extensions/sandboxed_extension_unpacker.cc (revision 65541)

+++ chrome/browser/extensions/sandboxed_extension_unpacker.cc (working copy)

@@ -228,6 +228,10 @@

ReportFailure("Key length is zero");

return false;

}

+ if (header.signature_size == 0) {

+ ReportFailure("Signature length is zero");

+ return false;

+ }

std::vector<uint8> key;

key.resize(header.key_size);

« no previous file with comments | « no previous file | no next file » | no next file with comments »