SandboxedExtensionUnpacker::ValidateSignature should check for an empty signa...

SandboxedExtensionUnpacker::ValidateSignature should check for an empty signature

Without an expicit check we crash on a hard int3 when trying to allocate 0 bytes.

BUG=62791
TEST=None.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65821

[jschuh, 2010-11-11 17:13:51]

Simple fix for a report we got this morning.

[Erik does not do reviews, 2010-11-11 17:28:04]

LGTM.  thanks.

On Thu, Nov 11, 2010 at 9:13 AM, <jschuh@chromium.org> wrote:

> Reviewers: aa.chromium, Erik Kay,
>
> Message:
> Simple fix for a report we got this morning.
>
> Description:
> SandboxedExtensionUnpacker::ValidateSignature should check for an empty
> signature
>
> Without an expicit check we crash on a hard int3 when trying to allocate 0
> bytes.
>
> BUG=62791
> TEST=None.
>
> Please review this at http://codereview.chromium.org/4723007/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/extensions/sandboxed_extension_unpacker.cc
>
>
> Index: chrome/browser/extensions/sandboxed_extension_unpacker.cc
> ===================================================================
> --- chrome/browser/extensions/sandboxed_extension_unpacker.cc   (revision
> 65541)
> +++ chrome/browser/extensions/sandboxed_extension_unpacker.cc   (working
> copy)
> @@ -228,6 +228,10 @@
>     ReportFailure("Key length is zero");
>     return false;
>   }
> +  if (header.signature_size == 0) {
> +    ReportFailure("Signature length is zero");
> +    return false;
> +  }
>
>   std::vector<uint8> key;
>   key.resize(header.key_size);
>
>
>