Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/test_launcher_utils.cc

Issue 4723006: Add test fixture for GPU browser tests which do image comparisons.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/gpu/gpu_pixel_browsertest.cc ('K') | « chrome/test/gpu/gpu_pixel_browsertest.cc ('k') | chrome/test/ui_test_utils.h » ('j') | chrome/test/ui_test_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/test_launcher_utils.cc
===================================================================
--- chrome/test/test_launcher_utils.cc (revision 65433)
+++ chrome/test/test_launcher_utils.cc (working copy)
@@ -35,9 +35,12 @@
// TODO(apatrick): Other pending changes will fix this for mac.
#if !defined(OS_MACOSX)
- // Force all tests to use OSMesa if they launch the GPU process.
- command_line->AppendSwitchASCII(switches::kUseGL,
- gfx::kGLImplementationOSMesaName);
+ if (!command_line->HasSwitch(switches::kUseGL)) {
apatrick_chromium 2010/11/15 22:10:23 This code is now deleted.
kkania 2010/11/15 23:09:16 Done.
+ // Force all tests to use OSMesa if they launch the GPU process without
+ // explicitly specifying a GL implementation.
+ command_line->AppendSwitchASCII(switches::kUseGL,
+ gfx::kGLImplementationOSMesaName);
+ }
#endif
}
« chrome/test/gpu/gpu_pixel_browsertest.cc ('K') | « chrome/test/gpu/gpu_pixel_browsertest.cc ('k') | chrome/test/ui_test_utils.h » ('j') | chrome/test/ui_test_utils.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698