Fix a crash caused by garbage collection during generation of a...

Fix a crash caused by garbage collection during generation of a
callback load (or keyed load) IC.

The problem was that the IC code calls a stub, which can allocate and
thus trigger a GC if the stub is not already generated.  Problem is
solved by adding the ability to "try" to call a stub, trying to
generate the stub code if necessary but signaling an allocation
failure if generating the code is not possible.


Committed: http://code.google.com/p/v8/source/detail?r=3440

[Mads Ager (chromium), 2009-12-09 13:21:30]

LGTM.  Are these not implemented in the 64-bit version or the ARM version?

http://codereview.chromium.org/472002/diff/1/3
File src/ia32/stub-cache-ia32.cc (right):

http://codereview.chromium.org/472002/diff/1/3#newcode1444
src/ia32/stub-cache-ia32.cc:1444: Failure* failure;
Initialize to internal error or something?

http://codereview.chromium.org/472002/diff/1/3#newcode1612
src/ia32/stub-cache-ia32.cc:1612: Failure* failure;
Ditto.

[Kevin Millikin (Chromium), 2009-12-09 14:53:37]

The ApiGetterEntryStub stub is not implemented on x64 or arm.

http://codereview.chromium.org/472002/diff/1/3
File src/ia32/stub-cache-ia32.cc (right):

http://codereview.chromium.org/472002/diff/1/3#newcode1444
src/ia32/stub-cache-ia32.cc:1444: Failure* failure;
On 2009/12/09 13:21:30, Mads Ager wrote:
> Initialize to internal error or something?

OK

http://codereview.chromium.org/472002/diff/1/3#newcode1612
src/ia32/stub-cache-ia32.cc:1612: Failure* failure;
On 2009/12/09 13:21:30, Mads Ager wrote:
> Ditto.

Ditto