Issue 4719002: AU: Remove obsolete SetBootableFlagAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4719002: AU: Remove obsolete SetBootableFlagAction. (Closed)

Created:
10 years, 1 month ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git@master

Visibility:
Public.

Description

AU: Remove obsolete SetBootableFlagAction. BUG=6251 TEST=unit tests, tested on device Change-Id: If1b28d47287abeb0a507d77aa3790fdf39d6513a Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d34a421

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -182 lines)			Patch
M	SConstruct	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	action_processor.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	set_bootable_flag_action.h	View	1 chunk	+0 lines, -55 lines	0 comments	Download
D	set_bootable_flag_action.cc	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	set_bootable_flag_action_unittest.cc	View	1 chunk	+0 lines, -33 lines	0 comments	Download
M	update_attempter.cc	View	5 chunks	+0 lines, -8 lines	2 comments	Download
M	update_attempter_unittest.cc	View	3 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ question http://codereview.chromium.org/4719002/diff/1/7 File update_attempter.cc (right): http://codereview.chromium.org/4719002/diff/1/7#newcode164 update_attempter.cc:164: shared_ptr<PostinstallRunnerAction> postinstall_runner_action_postcommit( you may want to ...

10 years, 1 month ago (2010-11-08 22:54:07 UTC) #2

petkov

10 years, 1 month ago (2010-11-08 22:56:53 UTC) #3

I'll push as is. And submit another CL for --postcommit.

http://codereview.chromium.org/4719002/diff/1/7
File update_attempter.cc (right):

http://codereview.chromium.org/4719002/diff/1/7#newcode164
update_attempter.cc:164: shared_ptr<PostinstallRunnerAction>
postinstall_runner_action_postcommit(
On 2010/11/08 22:54:07, adlr wrote:
> you may want to delete this now? or is this in a separate CL?

I thought it's going to be cleaner in a separate CL.

Expand Messages | Collapse Messages