Pickle: handle invalid data on 64 bit systems....

base/pickle.h

Index: base/pickle.h
===================================================================
--- base/pickle.h	(revision 65620)
+++ base/pickle.h	(working copy)
@@ -180,7 +180,7 @@
     return payload() + payload_size();
   }
   const char* end_of_payload() const {
-    return payload() + payload_size();
+    return header_ ? payload() + payload_size() : NULL;

[darin (slow to review), 2010/11/11 17:33:57]

what about the non-const version of end_of_payload?

[rvargas (doing something else), 2010/11/11 22:35:36]

The expectation for the non-const version is to have a valid header_ (it should
come from a different constructor). I could DCHECK that, but it will require
changing the signature and moving the method to the cc file. (As is, the process
will crash reading from 0 on payload_size(), so in practice we are CHECKing that
it is not null). Let me know if you prefer an explicit CHECK or DCHECK.

I added comments.

   }
 
   size_t capacity() const {