Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 4713003: Revert a workaround & exclude filters for TSan/Win failures... (Closed)

Created:
10 years, 1 month ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert a workaround & exclude filters for TSan/Win failures a) Unknown nonzero error codes disappeared after the bot recovery (it was showing a "Recovered from a BSOD" message) b) The CookieMonster tests were failing due to slow stl checks in Debug mode. This should be fixed by r65377 and r65384 BUG=62512, 59642 TEST=TSan/Win should remain green TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/valgrind/valgrind_test.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Timur Iskhodzhanov
10 years, 1 month ago (2010-11-10 10:00:16 UTC) #1
Alexander Potapenko
10 years, 1 month ago (2010-11-10 16:11:59 UTC) #2
LG

On Wed, Nov 10, 2010 at 1:00 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Revert a workaround & exclude filters for TSan/Win failures
> a) Unknown nonzero error codes disappeared after the bot recovery
>   (it was showing a "Recovered from a BSOD" message)
> b) The CookieMonster tests were failing due to slow stl checks in Debug
> mode.
>   This should be fixed by r65377 and r65384
> BUG=62512,59642
> TEST=TSan/Win should remain green
> TBR=glider
>
> Please review this at http://codereview.chromium.org/4713003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt
>  M     tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt
>  M     tools/valgrind/valgrind_test.py
>
>
> Index: tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt
> ===================================================================
> --- tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt
> (revision 65509)
> +++ tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt
> (working copy)
> @@ -2,10 +2,6 @@
>  HttpNetworkTransactionTest.*
>  HttpNetworkLayerTest.GET
>
> -# These take too long in Debug build, see http://crbug/59642
> -CookieMonsterTest.GarbageCollectionTriggers
> -CookieMonsterTest.TestHostGarbageCollection
> -
>  # TODO(timurrrr): investigate these
>  ClientSocketPoolBaseTest.*
>  SSLClientSocketTest.*
> Index: tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt
> ===================================================================
> --- tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt
> (revision 65509)
> +++ tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt
> (working copy)
> @@ -21,9 +21,6 @@
>  HttpNetworkTransactionTest.*
>  HttpNetworkLayerTest.GET
>
> -# Timing out under TSan, see http://crbug.com/59642
> -CookieMonsterTest.GarbageCollectionTriggers
> -
>  #########################################
>  # These tests fail if you don't have our SSL certificate installed.
>  # Please see http://dev.chromium.org/developers/testing#TOC-SSL-tests
> Index: tools/valgrind/valgrind_test.py
> ===================================================================
> --- tools/valgrind/valgrind_test.py     (revision 65538)
> +++ tools/valgrind/valgrind_test.py     (working copy)
> @@ -707,12 +707,7 @@
>       logging.info(self.INFO_MESSAGE)
>     return ret
>
> -  # TODO(timurrrr): temporary workaround for http://crbug.com/62512
> -  def Execute(self):
> -    super(ThreadSanitizerWindows, self).Execute()
> -    return 0
>
> -
>  class DrMemory(BaseTool):
>   """Dr.Memory
>   Dynamic memory error detector for Windows.
>
>
>

Powered by Google App Engine
This is Rietveld 408576698