Issue 471008: Misc. fixes to versioning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 471008: Misc. fixes to versioning. (Closed)

Created:
11 years ago by djmm

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

Deal with empty build_number in archive_build.sh. Set and pass-thru REAL_USER for use in chroots. Remove extraneous CHROMEOS_VERSION_* settings from chromeos_version.sh.

Patch Set 1 #

Total comments: 1

Patch Set 2 : versioning2 #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
M	src/scripts/archive_build.sh	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/scripts/build_image.sh	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/scripts/chromeos_version.sh	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/scripts/customize_rootfs.sh	View	1	1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adlr

11 years ago (2009-12-09 03:02:36 UTC) #2

LGTM w/ comment

http://codereview.chromium.org/471008/diff/1/5
File src/scripts/customize_rootfs.sh (right):

http://codereview.chromium.org/471008/diff/1/5#newcode48
src/scripts/customize_rootfs.sh:48: export
CHROMEOS_VERSION_DESCRIPTION="${CHROMEOS_VERSION_STRING} (Official Build
${CHROMEOS_REVISION:?})"
indent everything by 2 in this file

Expand Messages | Collapse Messages