chrome/browser/resources/new_new_tab.js - Issue 4708002: Add a histogram for tracking web store promo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/new_new_tab.js

Issue 4708002: Add a histogram for tracking web store promo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: feedback Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/new_new_tab.js

diff --git a/chrome/browser/resources/new_new_tab.js b/chrome/browser/resources/new_new_tab.js

index 6b3be4ad5560bb9e2ead69d5f11da662574cb817..89deeeff8a30f4927a6d985efb22f65605e83b3c 100644

--- a/chrome/browser/resources/new_new_tab.js

+++ b/chrome/browser/resources/new_new_tab.js

@@ -1206,7 +1206,10 @@ function isDoneLoading() {

document.addEventListener('DOMContentLoaded', function() {

var promoText1 = $('apps-promo-text1');

promoText1.innerHTML = promoText1.textContent;

- promoText1.querySelector('a').href = localStrings.getString('web_store_url');

+ var promoLink = promoText1.querySelector('a');

+ promoLink.id = 'apps-promo-link';

+ promoLink.href = localStrings.getString('web_store_url');

$('apps-promo-hide').addEventListener('click', function() {

chrome.send('hideAppsPromo', []);