chrome/browser/dom_ui/new_tab_ui.cc - Issue 4708002: Add a histogram for tracking web store promo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_ui/new_tab_ui.cc

Issue 4708002: Add a histogram for tracking web store promo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: feedback Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/dom_ui/new_tab_ui.cc

diff --git a/chrome/browser/dom_ui/new_tab_ui.cc b/chrome/browser/dom_ui/new_tab_ui.cc

index a6621026a946daaeab375912be7b9a32f3450b7f..e1024715e677819fc40b171aa8e108a262e5d206 100644

--- a/chrome/browser/dom_ui/new_tab_ui.cc

+++ b/chrome/browser/dom_ui/new_tab_ui.cc

@@ -620,7 +620,9 @@ void NewTabUI::NewTabHTMLSource::StartDataRequest(const std::string& path,

int request_id) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

- if (!path.empty() && path[0] != '#') {

+ if (AppLauncherHandler::HandlePing(path)) {

+ return;

+ } else if (!path.empty() && path[0] != '#') {

// A path under new-tab was requested; it's likely a bad relative

// URL from the new tab page, but in any case it's an error.

NOTREACHED();