Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 4705007: Don't restrict supported media types in test_shell when running interactively (Closed)

Created:
10 years, 1 month ago by Marshall
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Don't restrict supported media types in test_shell when running interactively. BUG=62828 TEST=See bug report Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65945

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M webkit/tools/test_shell/test_shell_webkit_init.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Marshall
Please review.
10 years, 1 month ago (2010-11-11 18:52:41 UTC) #1
scherkus (not reviewing)
http://codereview.chromium.org/4705007/diff/6001/webkit/tools/test_shell/test_shell_webkit_init.cc File webkit/tools/test_shell/test_shell_webkit_init.cc (right): http://codereview.chromium.org/4705007/diff/6001/webkit/tools/test_shell/test_shell_webkit_init.cc#newcode24 webkit/tools/test_shell/test_shell_webkit_init.cc:24: : mime_registry_(layout_test_mode) { what about creating a webkit_glue::SimpleWebMimeRegistryImpl instead?
10 years, 1 month ago (2010-11-11 19:27:00 UTC) #2
Marshall
On 2010/11/11 19:27:00, scherkus wrote: > what about creating a webkit_glue::SimpleWebMimeRegistryImpl instead? Good idea, that's ...
10 years, 1 month ago (2010-11-11 19:41:12 UTC) #3
scherkus (not reviewing)
ahh much simpler :) LGTM and have fun watching videos!
10 years, 1 month ago (2010-11-11 19:47:51 UTC) #4
Marshall
On 2010/11/11 19:47:51, scherkus wrote: > ahh much simpler :) > > LGTM and have ...
10 years, 1 month ago (2010-11-11 19:51:27 UTC) #5
Timur Iskhodzhanov
Looks like Memory Waterfall didn't like this change - all WebKit bots gone red. Can ...
10 years, 1 month ago (2010-11-12 17:36:53 UTC) #6
Marshall Greenblatt
Looking... On Fri, Nov 12, 2010 at 12:36 PM, <timurrrr@chromium.org> wrote: > Looks like Memory ...
10 years, 1 month ago (2010-11-12 18:02:47 UTC) #7
Marshall Greenblatt
10 years, 1 month ago (2010-11-12 18:28:00 UTC) #8
SimpleWebMimeRegistryImpl needs a virtual destructor, committing now.

On Fri, Nov 12, 2010 at 1:02 PM, Marshall Greenblatt <magreenblatt@gmail.com
> wrote:

> Looking...
>
>
> On Fri, Nov 12, 2010 at 12:36 PM, <timurrrr@chromium.org> wrote:
>
>> Looks like Memory Waterfall didn't like this change - all WebKit bots gone
>> red.
>> Can you please take a look?
>>
>>
>> http://codereview.chromium.org/4705007/
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698