Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Unified Diff: tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py

Issue 4704006: Add version information to the policy templates (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: fix typo in merge Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py
diff --git a/tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py b/tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py
index 15ccc6892b7d6b61bd71d3c0e3f8fa80983afcbf..8f1ec8ce9f2a045ec2dbb9395b5579d5e269844f 100644
--- a/tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py
+++ b/tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py
@@ -283,13 +283,18 @@ MockKey\\PolicyName\\1 = &quot;Bar&quot;</dd><dt>Linux:</dt><dd style="style_.mo
'name': 'TestPolicyName',
'caption': 'TestPolicyCaption',
'desc': 'TestPolicyDesc',
- 'annotations': {
+ 'supported_on': [{
+ 'product': 'chrome',
'platforms': ['win'],
- 'products': ['chrome'],
+ 'since_version': '8',
+ 'until_version': '',
+ }],
+ 'annotations': {
'features': {'dynamic_refresh': 0},
'example_value': False
}
}
+ self.writer.messages.msg_dict['since_version'] = '...$6...'
self.writer._AddPolicyDetails(self.doc_root, policy)
self.assertEquals(
self.doc_root.toxml(),
@@ -299,8 +304,12 @@ MockKey\\PolicyName\\1 = &quot;Bar&quot;</dd><dt>Linux:</dt><dd style="style_.mo
'<dd style="style_.monospace;">MockKey\TestPolicyName</dd>'
'<dt style="style_dt;">_test_mac_linux_pref_name</dt>'
'<dd style="style_.monospace;">TestPolicyName</dd>'
- '<dt style="style_dt;">_test_supported_on_platforms</dt><dd>Windows</dd>'
- '<dt style="style_dt;">_test_supported_in_products</dt><dd>Chrome</dd>'
+ '<dt style="style_dt;">_test_supported_on</dt>'
+ '<dd>'
+ '<ul style="style_ul;">'
+ '<li>Chrome (Windows) ...8...</li>'
+ '</ul>'
+ '</dd>'
'<dt style="style_dt;">_test_supported_features</dt>'
'<dd>Dynamic Policy Refresh: _test_not_supported</dd>'
'<dt style="style_dt;">_test_description</dt><dd>TestPolicyDesc</dd>'
@@ -363,13 +372,18 @@ MockKey\\PolicyName\\1 = &quot;Bar&quot;</dd><dt>Linux:</dt><dd style="style_.mo
'caption': 'PolicyCaption',
'desc': 'PolicyDesc',
'type': 'string',
- 'annotations': {
+ 'supported_on': [{
+ 'product': 'chrome',
'platforms': ['win'],
- 'products': ['chrome'],
+ 'since_version': '7',
+ 'until_version': '',
+ }],
+ 'annotations': {
'features': {'dynamic_refresh': 0},
'example_value': False
}
}
+ self.writer.messages.msg_dict['since_version'] = '..$6..'
self.writer._AddPolicySection(self.doc_root, policy)
self.assertEquals(
self.doc_root.toxml(),
@@ -384,10 +398,12 @@ MockKey\\PolicyName\\1 = &quot;Bar&quot;</dd><dt>Linux:</dt><dd style="style_.mo
'<dd style="style_.monospace;">MockKey\\PolicyName</dd>'
'<dt style="style_dt;">_test_mac_linux_pref_name</dt>'
'<dd style="style_.monospace;">PolicyName</dd>'
- '<dt style="style_dt;">_test_supported_on_platforms</dt>'
- '<dd>Windows</dd>'
- '<dt style="style_dt;">_test_supported_in_products</dt>'
- '<dd>Chrome</dd>'
+ '<dt style="style_dt;">_test_supported_on</dt>'
+ '<dd>'
+ '<ul style="style_ul;">'
+ '<li>Chrome (Windows) ..7..</li>'
+ '</ul>'
+ '</dd>'
'<dt style="style_dt;">_test_supported_features</dt>'
'<dd>Dynamic Policy Refresh: _test_not_supported</dd>'
'<dt style="style_dt;">_test_description</dt>'

Powered by Google App Engine
This is Rietveld 408576698