Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 4703004: Update the EventSendingController to send complete touch events. (Closed)

Created:
10 years, 1 month ago by rjkroege
Modified:
9 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Update the EventSendingController to send complete touch events. The patch makes EventSendingController send touch events more like how it currently handles mouse events: give them valid screenPosition fields and do layout before dispatching them. BUG=none TEST=via layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66159

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webkit/tools/test_shell/event_sending_controller.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rjkroege
Similar to the previous bug. Improved touch event delivery. Matching WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=49285
10 years, 1 month ago (2010-11-10 18:39:38 UTC) #1
jamesr
http://codereview.chromium.org/4703004/diff/1/webkit/tools/test_shell/event_sending_controller.cc File webkit/tools/test_shell/event_sending_controller.cc (right): http://codereview.chromium.org/4703004/diff/1/webkit/tools/test_shell/event_sending_controller.cc#newcode926 webkit/tools/test_shell/event_sending_controller.cc:926: // that send an event do). Comment isn't very ...
10 years, 1 month ago (2010-11-10 19:59:57 UTC) #2
rjkroege
On 2010/11/10 19:59:57, jamesr wrote: > http://codereview.chromium.org/4703004/diff/1/webkit/tools/test_shell/event_sending_controller.cc > File webkit/tools/test_shell/event_sending_controller.cc (right): > > http://codereview.chromium.org/4703004/diff/1/webkit/tools/test_shell/event_sending_controller.cc#newcode926 > ...
10 years, 1 month ago (2010-11-10 20:25:12 UTC) #3
jamesr
10 years, 1 month ago (2010-11-10 20:33:44 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698