Fix flaw in VirtualFrame::SetElementAt handling multiple copies of elements.

Fix flaw in VirtualFrame::SetElementAt handling multiple copies of elements.

Committed: http://code.google.com/p/v8/source/detail?r=1577

[Kevin Millikin (Chromium), 2009-03-23 14:21:01]

LGTM other than a couple of style issues.

While you're at it, you could make the loop in StoreToFrameSlotAt work the same
way (just changing the index of all the copies, rather than resetting them). 
It's a little faster and a lot clearer.

http://codereview.chromium.org/47006/diff/1/2
File src/virtual-frame.cc (right):

http://codereview.chromium.org/47006/diff/1/2#newcode393
Line 393: break;
If the single-line body of an if statement is on a new line, surround it with
braces.

http://codereview.chromium.org/47006/diff/1/2#newcode406
Line 406: elements_[i] = CopyElementAt(frame_index);
We might consider preserving the sync flag on elements_[i] (there is code in
StoreToFrameSlot that tries to do that, but it looks like it doesn't even work
for registers).

http://codereview.chromium.org/47006/diff/1/2#newcode407
Line 407: for (int j = i+1; j < elements_.length(); j++) {
Space around the binary operator.

[William Hesse, 2009-03-23 15:02:52]

http://codereview.chromium.org/47006/diff/1/2
File src/virtual-frame.cc (right):

http://codereview.chromium.org/47006/diff/1/2#newcode393
Line 393: break;
On 2009/03/23 14:21:01, Kevin Millikin wrote:
> If the single-line body of an if statement is on a new line, surround it with
> braces.

Done.

http://codereview.chromium.org/47006/diff/1/2#newcode406
Line 406: elements_[i] = CopyElementAt(frame_index);
On 2009/03/23 14:21:01, Kevin Millikin wrote:
> We might consider preserving the sync flag on elements_[i] (there is code in
> StoreToFrameSlot that tries to do that, but it looks like it doesn't even work
> for registers).

Done.

http://codereview.chromium.org/47006/diff/1/2#newcode407
Line 407: for (int j = i+1; j < elements_.length(); j++) {
On 2009/03/23 14:21:01, Kevin Millikin wrote:
> Space around the binary operator.

Done.