Added IME tests for web forms

client/site_tests/desktopui_ImeTest/desktopui_ImeTest.py

 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os, string, time, gtk
 from autotest_lib.client.bin import site_ui_test, test
-from autotest_lib.client.common_lib import error, site_ui, utils
+from autotest_lib.client.common_lib import error, site_ui, utils, site_httpd
 
 
 class desktopui_ImeTest(site_ui_test.UITest):
     version = 1
     preserve_srcdir = True
 
     def setup(self):
         # TODO: We shouldn't use ibusclient, we should talk to Chrome directly
         self.job.setup_dep(['ibusclient'])
 
+    def initialize(self, creds='$default'):
+        self._test_url = 'http://localhost:8000/interaction_form.html'
+        self._testServer = site_httpd.HTTPListener(8000, docroot=self.bindir)
+        self._testServer.run()
+
+        site_ui_test.UITest.initialize(self, creds)
+

[Zachary Kuznia, 2010/11/10 09:15:55]

Nit:  Two lines between functions.

[timothe, 2010/11/16 10:02:52]

Done.

+    def cleanup(self):
+        self._testServer.stop()
+        site_ui_test.UITest.cleanup(self)
+
 
     def log_error(self, test_name, message):
         self.job.record('ERROR', None, test_name, message)
         self._failed.append(test_name)
 
 
     # TODO(zork) We should share this with platform_ProcessPrivleges.
     # See: crosbug.com/7453
     def check_process(self, process, user=None):
         """Check if the process is running as the specified user / root.
@@ skipping 169 matching lines @@
             current_engine = self.get_active_engine()
             if current_engine == expected_other_engine:
                 ax.send_hotkey('Ctrl-space')
                 return
             time.sleep(1)
         self.log_error('test_keyboard_shortcut',
                        'Current engine is %s, expected %s' %
                        (current_engine, expected_other_engine))
 
 
-    def test_engine(self, engine_name, input_string, expected_string):
+    def test_engine_omnibox(self, engine_name, input_string, expected_string):
         self.preload_engines([engine_name])
         self.activate_engine(engine_name)
 
         ax = self.get_autox()
-

[Zachary Kuznia, 2010/11/10 09:15:55]

Nit: No need to remove these lines.

[timothe, 2010/11/16 10:02:52]

Done.

         # Focus on the omnibox so that we can enter text.
         ax.send_hotkey('Ctrl-l')
-
         # Sometimes there is a slight delay before input can be received in the
         # omnibox.
         time.sleep(1)
 
         ax.send_text(input_string)
 
         text = self.get_current_text()
         if text != expected_string:
             self.log_error(
                 'test_engine %s' % engine_name,
-                'Engine %s failed: Got %s, expected %s' % (engine_name, text,
+                'Engine %s failed in omnibox: Got %s, expected %s' % (engine_name, text,

[Zachary Kuznia, 2010/11/10 09:15:55]

Nit: Line is greater than 80 characters.

[timothe, 2010/11/16 10:02:52]

Done.

                                                            expected_string))
+        ax.send_hotkey('BackSpace')

[Zachary Kuznia, 2010/11/10 09:15:55]

What does this line add?

[timothe, 2010/11/16 10:02:52]

Before we were opening a new tab and closing it, now we just refresh because we
want to use the same form at the same address so we need a way to clear the
omnibox in case previous tests failed.
On 2010/11/10 09:15:55, Zachary Kuznia wrote:

[Zachary Kuznia, 2010/11/10 09:15:55]

Nit: Two lines between functions.

[timothe, 2010/11/16 10:02:52]

Done.

+    def test_engine_form(self, engine_name, input_string, expected_string):
+        self.preload_engines([engine_name])
+        self.activate_engine(engine_name)
+
+        ax = self.get_autox()
+        ax.send_hotkey('Ctrl-r')
+        ax.send_text(input_string)
+        text = self.get_current_text()
+        if text != expected_string:
+            self.log_error(
+                'test_engine %s' % engine_name,
+                'Engine %s failed in form text input: Got %s, expected %s' % (
+                    engine_name, text, expected_string))
 

[Zachary Kuznia, 2010/11/10 09:15:55]

Nit: Two lines between functions.

[timothe, 2010/11/16 10:02:52]

Done.

     def run_once(self):
         self._failed = []
         dep = 'ibusclient'
         dep_dir = os.path.join(self.autodir, 'deps', dep)
         self.job.install_pkg(dep, 'dep', dep_dir)
 
         self.exefile = os.path.join(self.autodir,
                                     'deps/ibusclient/ibusclient')
 
         # Before we try to activate the options menu, we need to wait for
         # previous actions to complete.  Most notable is that keystrokes
         # immediately after login get lost.
         time.sleep(5)
 
+        #starting a session and waiting for the page to come up

[Zachary Kuznia, 2010/11/10 09:15:55]

Nit: Space between # and starting, capitalize and add a period.

[timothe, 2010/11/16 10:02:52]

Done.

+        session = site_ui.ChromeSession(self._test_url)
+        time.sleep(3)
+
         self.test_ibus_start_process()
 
         self.check_process('candidate_window', user='chronos')
         self.check_process('ibus-daemon', user='chronos')
         self.check_process('ibus-memconf', user='chronos')
 
         self.test_keyboard_shortcut()
-        self.test_engine('mozc', 'nihongo \n',
+        self.test_engine_omnibox('mozc', 'nihongo \n',
                          '\xE6\x97\xA5\xE6\x9C\xAC\xE8\xAA\x9E')
-        self.test_engine('chewing', 'hol \n', '\xE6\x93\x8D')
-        self.test_engine('hangul', 'wl ', '\xEC\xA7\x80 ')
-        self.test_engine('pinyin', 'nihao ', '\xE4\xBD\xA0\xE5\xA5\xBD')
-        self.test_engine('m17n:zh:quick', 'aa', '\xE9\x96\x93')
+        self.test_engine_omnibox('chewing', 'hol \n', '\xE6\x93\x8D')
+        self.test_engine_omnibox('hangul', 'wl ', '\xEC\xA7\x80 ')
+        self.test_engine_omnibox('pinyin', 'nihao ', '\xE4\xBD\xA0\xE5\xA5\xBD')
+        self.test_engine_omnibox('m17n:zh:quick', 'aa ', '\xE9\x96\x93')
+
+        self.test_engine_form('mozc', 'nihongo \n',
+                         '\xE6\x97\xA5\xE6\x9C\xAC\xE8\xAA\x9E')

[Zachary Kuznia, 2010/11/10 09:15:55]

Nit: The ' should line up one space after the ( above.

[timothe, 2010/11/16 10:02:52]

Done.

+        self.test_engine_form('chewing', 'hol \n', '\xE6\x93\x8D')
+        self.test_engine_form('hangul', 'wl ', '\xEC\xA7\x80 ')
+        self.test_engine_form('pinyin', 'nihao ', '\xE4\xBD\xA0\xE5\xA5\xBD')
+        self.test_engine_form('m17n:zh:quick', 'aa ', '\xE9\x96\x93')
 
         # Run a test on English last, so that we can type in English to
         # turn off the IME.
-        self.test_engine('xkb:us::eng', 'asdf', 'asdf')
+        self.test_engine_omnibox('xkb:us::eng', 'asdf', 'asdf')
+        self.test_engine_form('xkb:us::eng', 'asdf', 'asdf')

[Zachary Kuznia, 2010/11/10 09:15:55]

FYI: This line won't be needed once you sync and merge.

[timothe, 2010/11/16 10:02:52]

Done.

         self.test_ibus_stop_process()
+        session.close()
         if len(self._failed) != 0:
             raise error.TestFail(
                 'Failed: %s' % ','.join(self._failed))