Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 4698004: [Chrome OS] Cleanup and modify Chrome-for-ChromeOS autotest wrappers (Closed)

Created:
10 years, 1 month ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
zel
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

[Chrome OS] Cleanup and modify Chrome-for-ChromeOS autotest wrappers Some deps in the chrome tree and support classes on the Chrome OS side have changed, so update our autotest wrappers to work again. The new code also takes advantage of some new features in the ChromeTestBase class. I've also split the control files to each run 1/4 of the browser tests and ui tests. I tried to come up with a way to divide them more cleanly, but this seems the best way to split them across multiple VMs with the infrastructure on the bots. If we used autoserv to run smoke suite, we could be more clever here, but that's a big hammer for this problem. BUG=chromium-os:8544 TEST=install chrome with tests, then run desktopui_BrowserTest and friends. They should be able to run, though not necessarily succeed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -47 lines) Patch
A chrome/test/chromeos/autotest/files/client/deps/chrome_test/setup_test_links.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/control View 1 chunk +3 lines, -2 lines 0 comments Download
A chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/control.one View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/control.three View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/control.two View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py View 1 chunk +4 lines, -37 lines 0 comments Download
M chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py View 1 chunk +1 line, -5 lines 0 comments Download
A chrome/test/chromeos/autotest/files/client/site_tests/desktopui_UITest/control.one View 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/test/chromeos/autotest/files/client/site_tests/desktopui_UITest/control.three View 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/test/chromeos/autotest/files/client/site_tests/desktopui_UITest/control.two View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/test/chromeos/autotest/files/client/site_tests/desktopui_UITest/desktopui_UITest.py View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Masone
10 years, 1 month ago (2010-11-09 23:55:42 UTC) #1
zel
10 years, 1 month ago (2010-11-10 01:54:52 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698