Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 4697005: Part 3 of reapplying r64637. (Closed)

Created:
10 years, 1 month ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, amit, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Part 3 of reapplying r64637. This moves SecurityStyle and PageType into chrome/common/ and removes the chrome_frame dependency on chrome/browser/tab_contents/. This undoes the temporary DEPS hack on chrome/common/. BUG=51409 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65965

Patch Set 1 #

Patch Set 2 : Prune dead files from gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -66 lines) Patch
M chrome/browser/automation/testing_automation_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/navigation_controller.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/navigation_controller_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/navigation_entry.h View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/tab_contents/navigation_entry_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/common/automation_messages.h View 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/common/automation_messages_internal.h View 1 chunk +1 line, -2 lines 0 comments Download
A chrome/common/page_type.h View 1 chunk +17 lines, -0 lines 0 comments Download
A + chrome/common/security_style.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/automation/tab_proxy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_active_document.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
Final part. Undoes the DEPS crud.
10 years, 1 month ago (2010-11-10 22:45:07 UTC) #1
Elliot Glaysher
On 2010/11/10 22:45:07, Elliot Glaysher wrote: > Final part. Undoes the DEPS crud. ping
10 years, 1 month ago (2010-11-11 21:56:13 UTC) #2
Ben Goodger (Google)
10 years, 1 month ago (2010-11-11 23:45:06 UTC) #3 
LGTM

Powered by Google App Engine
This is Rietveld 408576698