Issue 4697004: [Mac] Better handling of nil for testing macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4697004: [Mac] Better handling of nil for testing macros. (Closed)

Created:
10 years, 1 month ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr., Robert Sesek

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Mac] Better handling of nil for testing macros. EXPECT_NSEQ() and EXPECT_NSNE() were implemented in terms of [x isEqual:y]. This meant that EXPECT_NSEQ(nil, nil) failed, and EXPECT_NSNE(nil, nil) succeeded. Add additional tests against the raw pointers to resolve this. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65710

Patch Set 1 #

Patch Set 2 : Comment about unable to test EXPECT_NSNE(nil, nil). #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	testing/gtest_mac.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	testing/gtest_mac_unittest.mm	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

10 years, 1 month ago (2010-11-10 19:08:39 UTC) #2

LG

I don't think there's a good way to test that EXPECT_NSNE(nil, nil) fails now –
maybe just add a comment to the test for that.

Expand Messages | Collapse Messages